Skip to content

Conversation

Dylan-DPC-zz
Copy link

Successful merges:

Failed merges:

r? @ghost

oli-obk and others added 21 commits December 15, 2019 09:42
…s̶dataflow, r=ecstatic-morse

Document more use cases of dataflow

r? @ecstatic-morse
Clean up some diagnostics by making them more consistent

In general:

- Diagnostic should start with a lowercase letter.
- Diagnostics should not end with a full stop.
- Ellipses contain three dots.
- Backticks should encode Rust code.

I also reworded a couple of messages to make them read more clearly.

It might be sensible to create a style guide for diagnostics, so these informal conventions are written down somewhere, after which we could audit the existing diagnostics.

r? @Centril
Specify units for test timeout environment variables

I think it is not obvious (I got it from reading libtest sources), so it is worth mentioning in docs.
…ities, r=Centril

restore some rustc_parse visibilities for rustfmt

In rust-lang@c189565 some visibilities were reduced on the parse mod (which now resides in the rustc_parse crate) as part of some refactoring and splitting up of libsyntax. However, rustfmt needs access to a few of those items that are no longer visible.

This restores the visibility on those items rustfmt depends on.

rust-lang/rustfmt#3903 (comment)
rust-lang/rustfmt#4009

cc @topecongiro
…t, r=Centril

Expose `context::CheckLintNameResult`

Clippy needs it

r? @Centril
@Dylan-DPC-zz Dylan-DPC-zz added the rollup A PR which is a rollup label Jan 12, 2020
@Dylan-DPC-zz
Copy link
Author

@bors r+ rollup=never p=7

@bors
Copy link
Collaborator

bors commented Jan 12, 2020

📌 Commit 30d7419 has been approved by Dylan-DPC

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 12, 2020
@bors
Copy link
Collaborator

bors commented Jan 12, 2020

⌛ Testing commit 30d7419 with merge 24127dc5d2ab9f6e92f2affff50cf643c2ec748a...

@bors
Copy link
Collaborator

bors commented Jan 12, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 12, 2020
@Dylan-DPC-zz
Copy link
Author

Failing spuriously.

@Dylan-DPC-zz Dylan-DPC-zz deleted the rollup-qpjve3v branch January 13, 2020 08:35
@Dylan-DPC-zz Dylan-DPC-zz restored the rollup-qpjve3v branch January 13, 2020 08:35
@Dylan-DPC-zz Dylan-DPC-zz deleted the rollup-qpjve3v branch January 13, 2020 08:35
@Dylan-DPC-zz Dylan-DPC-zz restored the rollup-qpjve3v branch January 13, 2020 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants